For the 'handler' callback arg to setUserData,  should that be a javascript
function? The DOM 3 API says that the handler has a signature of
  public void handle(short operation, String key, Object data, Node src,
Node dst);

So it would be kind of awkward to try to use a LzDelegate...




On Tue, Apr 28, 2009 at 5:12 PM, Max Carlson <[email protected]> wrote:

> Thanks!  I filed http://jira.openlaszlo.org/jira/browse/LPP-8122 to track
> the DOM 3 UserData improvements...
>
>
> André Bargull wrote:
>
>> I think the arguments for Debug.info() are in the wrong order, it should
>> be Debug.info("...", val, k) instead of Debug.info("...", k, val).
>> Otherwise approved.
>>
>> On 4/28/2009 10:49 PM, Max Carlson wrote:
>>
>>> Change 20090428-maxcarlson-v by maxcarl...@bank on 2009-04-28 13:40:00
>>> PDT
>>>    in /Users/maxcarlson/openlaszlo/trunk-clean
>>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Back out string coercion for lz.DataElement attribute values
>>>
>>> Bugs Fixed: LPP-8083 - LPP-8083 -
>>> LzDataElement.setAttribute('attributes', {...}) forces attribute values to
>>> strings
>>>
>>> Technical Reviewer: [email protected]
>>> QA Reviewer: [email protected]
>>>
>>> Release Notes: The upcoming release should note that lz.LzDataElement
>>> attribute values will be coerced to Strings in the future to be compliant
>>> with the DOM spec - see
>>> http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html#ID-F68F082.
>>>
>>>
>>> Details: Fix nits from reviewer - add * type for val, imrpove error
>>> message, change to a Debug.info() to be easily filtered, and back out String
>>> coercion for now.
>>>
>>> Tests: See LPP-8083 - you should get a message in the debugger, but the
>>> value should remain as-is.
>>>
>>> Files:
>>> M      WEB-INF/lps/lfc/data/LzDataElement.lzs
>>>
>>> Changeset:
>>> http://svn.openlaszlo.org/openlaszlo/patches/20090428-maxcarlson-v.tar
>>>
>>>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
>
>


-- 
Henry Minsky
Software Architect
[email protected]

Reply via email to