Approved! A few nits: please rename the quirk to not have a
browser-specific name. You never know when a quirk will have to be
turned on for another browser... Also, please put the quirk last in the
list - that way we get a rough idea of age for each quirk.
Bugs Fixed: LPP-8121
Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
+ See comment in LzInputTextSprite.js
// TODO [hqm 2009-06-09] LPP-8121 I discovered that if an
// input field is contained within a div which has a white
// background color, then it selected text will highlight with
// a dark blue color. The div can have zero width,
// Windows/Firefox only seems to look at the bgcolor of the
// containing div when deciding what color to use for input
// text highlight. So this adds an extra div, with zero width,
// in which the actual clickable/selectable input text element
// is placed.
Tests:
test case
+ in the lzmail app login window, if you type some text into the
username field,
and then select it, it should highlight in dark blue. In the app itself,
any input
field should also highlight as dark blue.
+ Selected text should highlight with dark blue, in Windows/Firefox3.
If it highlights with a light or white color, that is a bug.
<canvas width="100%" height="80%" bgcolor="#898989">
<inputtext id="e1">ABCDEFGHIJKLMNOPQRSTIVWYXZ 1234567890</inputtext>
</canvas>
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090610-hqm-H.tar
--
Regards,
Max Carlson
OpenLaszlo.org
