approved

On Fri, Jun 12, 2009 at 12:51 PM, P T Withington <[email protected]> wrote:

> [I plan to check this in and integrate it to 4.4 so Lorien can test it (and
> hopefully find the real, underlying bug).]
>
> Change 20090612-ptw-C by [email protected] on 2009-06-12 08:30:10
> EDT
>    in /Users/ptw/OpenLaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Be more careful in Class/nextMethod with compiler-private
> attributes
>
> Bugs Fixed: LPP-8264 No OL debugger in IE7, DHTML
>
> Technical Reviewer: hminsky (pending)
> QA Reviewer: [email protected] (pending)
>
> Details:
>    test/lpp-8264.lzx:  Contrived test to provoke the problem.  The
>    "real" test is for Lorien to run webtop with these changes.
>
>    Class.lzx, CommonGenerator.java: Renamed the compiler-private
>    properties of methods from `superclass.*` to `$superclass.*`.
>    User programs should not be using properties starting with `$` --
>    they are reserved for the compiler.  Made the compiler
>    optimization of super calls safer, and call to a non-existent
>    super method a no-op (that issues and error in debug mode).
>
>    Hopefully this will help find the _real_ bug.
>
> Tests:
>    Checked in a 'contrived' test that elicits a fatal error in dhtml
>    IE7.  With these changes, you now get an error in the LZX debugger
>    instead of halting
>
> Files:
> A      test/lpp-8264.lzx
> M      WEB-INF/lps/lfc/compiler/Class.lzs
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090612-ptw-C.tar
>



-- 
Henry Minsky
Software Architect
[email protected]

Reply via email to