Heads up, I'm not getting context menus coming up in DHTML after I updated to this change. I'm trying a clean build now...
On Fri, Sep 18, 2009 at 11:37 PM, "Max Carlson" <[email protected]> (JIRA) <[email protected]> wrote: > > [ > http://jira.openlaszlo.org/jira/browse/LPP-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Max Carlson updated LPP-8400: > ----------------------------- > > Status: Resolved (was: In Review) > Fixed in Change#: 14795 > Actually Fixed In: 4.7 (TRUNK) > Resolution: Fixed > > r14795 | max | 2009-09-18 20:34:10 -0700 (Fri, 18 Sep 2009) | 34 lines > Changed paths: > M /openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzContextMenuKernel.lzs > M /openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M /openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzSprite.as > M /openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzSprite.as > M /openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs > M /openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs > M /openlaszlo/trunk/lps/components/debugger/debugger.lzx > M /openlaszlo/trunk/lps/components/extensions/drawview.lzx > M /openlaszlo/trunk/lps/includes/source/excanvas.js > > Change 20090908-maxcarlson-6 by maxcarl...@bank on 2009-09-08 14:32:58 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED ONE MORE TIME: Move lz.drawview initialization into > sprites > > Bugs Fixed: LPP-8286 - DHTML: Improve look of context menu (partial), > LPP-8400 - Rename view.getMCRef() to a platform-neutral name > > Technical Reviewer: [email protected] > QA Reviewer: ptw > > Details: I applied Andre and ptw's suggestions. Works well in IE 7 and 8. > LPP-4128 works in IE 8 now, thanks to Andre's implementation of > http://groups.google.com/group/google-excanvas/browse_thread/thread/7e2065266af1cedd > > test/drawing/drawing - Add test from LPP-4128. > > swf/LzSprite - Add 2dcanvas capability, set to true. Add seek(), > getCurrentTime(), getTotalTime() and getID3() implementations. Expose > isaudio property. Add getDisplayObject(), setContextCallback() method - > unused in swf. Per Andre: make "isaudio" a getter on LzSprite, so it's > every time automatically up to date. > > dhtml/LzSprite - Add 2dcanvas capability, set to true. Move DHTML 2d > canvas setup/destroy/resize logic from drawview. Add better testing to > getContext() method to prevent errors in IE. Fix decrement order, clear > drawview timeout. Ensure IE gets at least a 50ms delay before attempting to > draw into the canvas. Use lz.embed.__setAttr() to bypass compiler > setAttribute() inlining. > > swf9/LzSprite - Add 2dcanvas capability, set to true. Rename getMCRef() to > getDisplayObject(). Add setContextCallback() method - unused in swf. > > LzText - Remove unused getMCRef() override > > LaszloView - Deprecate getMCRef(), recommend getDisplayObject() instead. > seek(), getCurrentTime(), getTotalTime() and getID3() now check to see if > the audio capability is true and call sprite implementations directly. Add > setter and basic implementation of getContext() which returns a 2d context > when available. > > debugger - Use getDisplayObject() API instead of deprecated getMCRef(). > > drawview - Use view.getContext() API to get the basic 2d context. Move > DHTML management code into the DHTML sprite. > > Tests: trunk-clean/examples/music/music.lzx in swf8 and swf9. > examples/extensions/drawing.lzx in all runtimes. > > skip-pre-commit-checks > > > Rename view.getMCRef() to a platform-neutral name > > ------------------------------------------------- > > > > Key: LPP-8400 > > URL: http://jira.openlaszlo.org/jira/browse/LPP-8400 > > Project: OpenLaszlo > > Issue Type: Improvement > > Components: Laszlo Foundation Classes (LFC) > > Affects Versions: 4.5 > > Reporter: Max Carlson > > Assignee: Max Carlson > > Fix For: 4.7 (TRUNK) > > > > > > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the administrators: > http://jira.openlaszlo.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: http://www.atlassian.com/software/jira > > > -- Henry Minsky Software Architect [email protected]
