Approved. Did I mention, you're the man? Your fixes always work the first time!
One cosmetic thing: + We try to avoid tying quirk names to specific browser, in case we need to turn the quirk on for another browser. Consider renaming quirks.ff_autoscroll_textarea to quirks.autoscroll_textarea. [email protected] wrote: > Change 20090624-Philip-2 by phi...@philip-dc on 2009-06-24 14:30:36 EDT > in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Firefox/DHTML: Add autoscrolling to inputtext/edittext > > New Features: > > Bugs Fixed: LPP-8277 > > Technical Reviewer: max > QA Reviewer: (pending) > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > Input text does not scroll properly in Firefox/dhtml. In IE and Safari > the user can scroll through the text with the mouse and insert text as > expected. In Firefox, text scrolls off the bottom of the window and only > the cursor keys can be used to see the missing text. The cause is > overflow:hidden that is applied to the <textarea> element. When the > scrollbars are not shown in Firefox it is difficult to move through the > text. > > I added a new quirk, ff_autoscroll_textarea. The > LzInputTextSprite#__textEvent handler has 2 new behaviors when this > quirk is true. First, it will scroll the window when you click/drag the > mouse up and down to expose the hidden text. Second, if the cursor is > placed at the end of the text, hitting a carriage return will also > scroll the text (when you type another character). > > This does not completely emulate what flash does or the behavior seen in > IE/dhtml, but it addresses the jira issue and also adds basic mouse > scrolling. > > Tests: > Test case in jira report. Compare before/after behavior in FF/dhtml. > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20090624-Philip-2.tar > -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
