Good catch. Review on its way... On 2009-07-10, at 11:38EDT, André Bargull wrote:
> If you return from "LzKeysService#gotKeyUp(..)" for the LPP-7012 > workaround, "downKeysArray" isn't set to the empty array. That needs > to be changed. > > > On 7/9/2009 10:35 PM, P T Withington wrote: >> Change 20090709-ptw-1 by [email protected] on 2009-07-09 >> 16:25:07 EDT >> in /Users/ptw/OpenLaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Make memory tracing work again >> >> Bugs Fixed: LPP-5222 Memory tracing does not work in DHTML >> >> Technical Reviewer: hminsky (pending) >> QA Reviewer: max (pending) >> >> Details: >> Memory tracing was experimentally working in DHTML, but caused it >> to rot in swf8. Make it work in both places again. DHTML is >> still marked as 'experimental' support. >> >> LzKeyboardKernel.*: Remove gratuitous consing of __downKeysHash >> >> LzKeys: Remove gratutious consing of downKeysArray >> >> LzIdle: Remove gratuitous consing of coi >> >> LzMemory: Remember that movieclips are not objects. Mark the >> Firebug console so it is not seen as a leak. >> >> debugger: There is no need for the commands to be global. >> >> Tests: >> Duplicated the examples from >> http://wiki.openlaszlo.org/Embedded_Debugger#Memory_Leaks >> >> Files: >> M WEB-INF/lps/lfc/kernel/swf/LzKeyboardKernel.as >> M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js >> M WEB-INF/lps/lfc/kernel/swf9/LzKeyboardKernel.as >> M WEB-INF/lps/lfc/services/LzKeys.lzs >> M WEB-INF/lps/lfc/services/LzIdle.lzs >> M WEB-INF/lps/lfc/debugger/LzMemory.lzs >> M lps/components/debugger/debugger.lzx >> >> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090709-ptw-1.tar >> _______________________________________________ >> Laszlo-reviews mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >> >> _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
