Okeydoke! -----Original Message----- From: P T Withington <[email protected]> Sent: Friday, July 10, 2009 1:45 PM To: Max Carlson <[email protected]> Cc: [email protected]; [email protected] Subject: Re: For Review: Change 20090707-ptw-J Summary: Part 1 of fixing stuck keys when IE loses focus
It didn't seem worth the trouble to complicate the code to save one slot in a hash table. On 2009-07-10, at 16:33EDT, Max Carlson wrote: > One small nit - since it's only required by the quirk, shouldn't > this line in WEB-INF/lps/lfc/kernel/swf/LzKeyboardKernel.as be > wrapped in the quirk declaration also? > > ,__listeneradded: false > > This can be addressed in the next round... > > P T Withington wrote: >> [I plan to check this in and start a build for testing] >> Change 20090707-ptw-J by [email protected] on 2009-07-07 >> 20:37:28 EDT >> in /Users/ptw/OpenLaszlo/4.2 >> for http://svn.openlaszlo.org/openlaszlo/branches/4.2 >> Summary: Part 1 of fixing stuck keys when IE loses focus >> Bugs Fixed: LPP-8283 Alt tab issue when switching tasks in IE7/Win >> Technical Reviewer: max (pending) >> QA Reviewer: hminsky (pending) >> Details: >> swf/LzSprite: Create a quirk for ActiveX which for some reason >> seems >> to swallow browser focus events, preventing us from using the >> solution that works for all other platforms of releasing all keys >> when the the browser window regains focus. >> swf/LzKeyboardKernel: Create a Selection listener for focus >> change, >> call __allKeysUp when focus moves to or from the app >> swf9/LFCApplication: For ActiveX embedding, create a Stage >> listener for ACTIVATE, call __allKeysUp when the app is activated. >> LzKeys, embednew: Add some debug info >> Tests: >> Still doesn't pass the test case, but it will remove the stuck key >> if you click on an input element >> Files: >> M WEB-INF/lps/lfc/kernel/swf/LzKeyboardKernel.as >> M WEB-INF/lps/lfc/kernel/swf/LzSprite.as >> M WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as >> M WEB-INF/lps/lfc/services/LzKeys.lzs >> M lps/includes/source/embednew.js >> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090707-ptw-J.tar > > -- > Regards, > Max Carlson > OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
