Then I approve your review request. :)
On 2009-07-18, at 14:38EDT, Max Carlson wrote:
> Good point! I fixed it to use this.
>
> P T Withington wrote:
>> why can't you just say:
>> <attribute name="target" value="$once{this.parent}" />
>> in the class definition, rather than hack the setter? Also, once
>> you do that, you should be able to remove this code from the
>> `oninit` handler:
>>> if (this['target'] == null) {
>>> this.setAttribute('target', this.parent);
>>> }
>> On 2009-07-17, at 22:45EDT, Max Carlson wrote:
>>> vn-re hange 20090717-maxcarlson-R by [email protected] on
>>> 2009-07-17 19:22:03 PDT
>>> in /Users/maxcarlson/openlaszlo/trunk-clean
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Make default target for html component this when one is not
>>> specified.
>>>
>>> Bugs Fixed: LPP-8044 - html component doesn't sync iframe if no
>>> target
>>> is provided
>>>
>>> Technical Reviewer: hminsky
>>> QA Reviewer: mdemmon
>>>
>>> Details: Make the default target this.
>>>
>>> Tests: webtop. Also load examples/extensions/html.lzx, click the
>>> 'Load' button then drag and resize the window in swf and dhtml.
>>>
>>> Files:
>>> M lps/components/extensions/html.lzx
>>>
>>> Changeset:
>>> http://svn.openlaszlo.org/openlaszlo/patches/20090717-maxcarlson-R.tar
>>> _______________________________________________
>>> Laszlo-reviews mailing list
>>> [email protected]
>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
