On 2009-08-14, at 09:31EDT, André Bargull wrote: > LzBacktrace.lzs: Only 'callee' and 'lineno' are deleted from the > args-object, why not 'this'?
I consider `this` to be the -1th argument, so it seemed reasonable to leave it in. > LzDebug.js: MouseEvent is not defined in all browsers (for example > IE), so 'thing instanceof MouseEvent' will throw a runtime error in > IE. And the switch for 'thing.button' won't work properly in IE, > because 'button' has got different values in IE > (http://msdn.microsoft.com/en-us/library/ms533544%28VS.85%29.aspx > ). Gah! I _hate_ IE. What is wrong with standards? Maybe I should just simplify it to use `instanceof Event` and `thing.type`. If you want more detail, you can inspect the event. (Inspecting works much better on native objects now that I am catching the error's trying to compare the object properties with the prototype properties.) > On 8/14/2009 2:54 PM, P T Withington wrote: >> Change 20090813-ptw-x by [email protected] on 2009-08-13 21:03:08 EDT >> in /Users/ptw/OpenLaszlo/trunk-2 >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Improve debugger printing of browser native objects >> >> Bugs Fixed: LPP-8375 onmouseout even on HTML component is firing >> onmouseover, not onmouseout (partial, this is to help debug it) >> >> Technical Reviewer: hminsky (pending) >> QA Reviewer: max (pending) >> >> Details: >> >> LzDebug, dhtml/LzDebug: Be more careful checking for own >> properties by wrapping try/catch more tightly around potential >> errors. >> >> dhtml/LzDebug: Print sprite implementation nodes in a more LZX >> way. Give MouseEvent's a prettier description. >> >> LzBacktrace: Remove the non-argument properties the compiler >> passes in the arglist to stack frames. >> >> Tests: >> IWFM >> >> Files: >> M WEB-INF/lps/lfc/debugger/LzDebug.lzs >> M WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js >> M WEB-INF/lps/lfc/debugger/LzBacktrace.lzs >> >> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090813-ptw-x.tar >> _______________________________________________ >> Laszlo-reviews mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >> >> _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
