Further: http://www.techy-talk.com/
Indicates that we should not rely on the contextmenu event if we want to be reasonably portable. Especially because some browsers don't send contextmenu until you mouseup, which is not really what you want (you want to be able to navigate the context menu with the mouse still down so that mouseup selects from the menu). I'm thinking we need to refine this a little more and use mouseup and button2 (unless there is a browser who gets that wrong, but that should be a quirk). On 2009-08-21, at 10:58EDT, Henry Minsky wrote: > Change 20090821-hqm-5 by [email protected] on 2009-08-21 10:48:29 EDT > in /Users/hqm/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: allow oncontextmenu to be sent even when context menu is > already open > > New Features: > > Bugs Fixed: LPP-8218 > > Technical Reviewer: max > QA Reviewer: ptw > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > > + the original bug which was being worked around seems to have been > fixed (the one where the Mac browser sent a left-click instead of > right click when using > the two-finger tap-click to simulate a right mouse button). > > I put in a debug print in LzMouseKernel.__mouseEvent, to see what > mouse events happen when I click right using two-finger tap on the > Mac. In FF/OSX and Safari OSX, and IE7/XP I see an 'oncontextmenu' > event being sent when I right click on the Mac. I also see a > "mousedown-right" event. The bug where a left click was sent seems to > have been fixed in the browser. > > LzMouseKernel: removes the workaround in __mouseEvent where mousedown- > right was > treated as 'oncontextmenu' event. > > LzContextMenuKernel: removes the "__sentshowevent" flag from the code > for displaying the menu > > There's still an issue about what seems like a duplicate onmouseup > event being sent in Safari when the right button is released, but > Tucker is looking at that. > > > Tests: > > test case from bug report > > + onmenuopen event should fire just once when menu is opened. > + If the context menu is already open, clicking right again SHOULD > sent another onmenuopen event > > <canvas debug="true" height="100%"> > <view width="200" height="200" bgcolor="0xff0000"> > <contextmenu name="cm" onmenuopen="Debug.write('opened menu')" > > <contextmenuitem caption="hello world"/> > </contextmenu> > </view> > </canvas> > > > Files: > > M WEB-INF/lps/lfc/kernel/dhtml/LzContextMenuKernel.lzs > M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js > > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090821-hqm-5.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
