So... Can I check this in? It's important for webtop! Max Carlson wrote: > That's correct. > > On Aug 24, 2009, at 6:47 AM, P T Withington wrote: > >> Ok. >> >> So you are pushing the sizing from the wrapper into the canvas, with >> the belief that there is enough control in the platforms now that we >> can do this, whereas in the past we could not? >> >> On 2009-08-22, at 17:39EDT, Max Carlson wrote: >> >>> P T Withington wrote: >>>> Because when we make the canvas different we get bug reports like >>>> the >>>> one to make the canvas resizable? >>> I don't think this will get in the way of making the canvas >>> resizable. >>> Resizing the canvas should ultimately update the size of the click >>> containers. After your fixes to canvas, the size should be >>> controlled >>> by the LFC, not the browser. Developers can set the width/height >>> attribute to null and have the canvas size to its contents, or hook >>> the >>> canvas size into a ratio of the screen size with a constraint. >>> >>>> We should strive to make it similar as possible. I understand >>>> making the >>>> div clip, I don't understand making the clickcontainer and the >>>> clickdiv >>>> clip. >>> The canvas size should determine what the app size is - without being >>> overridden by an oversized subview. I had to do add >>> overflow:hidden and >>> a size to make sure oversized click and context divs (which have a >>> width/height explicitly set by the sprite) don't overflow the canvas >>> containers - causing scrollbars to appear. In webtop this can happen >>> because contact items are 2000px wide - even though they're in a >>> clipped >>> view. Some browsers only respect overflow: - clip() isn't enough to >>> prevent the scrollbars >>> >>>> On Aug 22, 2009, at 15:07, Max Carlson <[email protected]> wrote: >>>> >>>>> Why should canvas divs use the same policy as their children? I >>>>> see >>>>> them as a special case - we explicitly want the canvas to be >>>>> clipped/contained. I changed this because before, we had overflow: >>>>> hidden on the body, which won't work for oversized apps... >>>>> >>>>> It seems like less overall computation to keep non-canvas >>>>> containers 0 >>>>> height/width and allow overflow. So, I'm in favor of keeping >>>>> things the >>>>> way they are. >>>>> >>>>> P T Withington wrote: >>>>>> I'd like to see the canvas be more in parallel with views. See >>>>>> >>>>>> http://jira.openlaszlo.org/jira/browse/LPP-8007 >>>>>> >>>>>> where Henry had to make the click containers _not_ overflow hidden >>>>>> (presumably because they have 0 size). You just commented on my >>>>>> change >>>>>> that I should _not_ have to size the click container, just the >>>>>> actual >>>>>> click div. >>>>>> >>>>>> So, we ought to have one policy for the canvas and the views, >>>>>> either the >>>>>> click (and context) containers have 0 size and allow overflow, >>>>>> or they >>>>>> have overflow:hidden but have to be resized. >>>>>> >>>>>> On 2009-08-21, at 21:12EDT, Max Carlson wrote: >>>>>> >>>>>>> Change 20090821-maxcarlson-Y by maxcarl...@bank on 2009-08-21 >>>>>>> 17:33:09 >>>>>>> PDT >>>>>>> in /Users/maxcarlson/openlaszlo/trunk-clean >>>>>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>>>>> >>>>>>> Summary: Eliminate scrollbars for oversized divs >>>>>>> >>>>>>> Bugs Fixed: LPP-8402 - DHTML: Extra scrollbar width on Safari and >>>>>>> windows firefox and IE 7 when wrapper has overflow: hidden >>>>>>> removed >>>>>>> >>>>>>> Technical Reviewer: ptw >>>>>>> QA Reviewer: hminsky >>>>>>> >>>>>>> Details: html-response - Remove overflow: hidden from default >>>>>>> CSS. >>>>>>> >>>>>>> LzSprite.js - Add overflow: hidden to lzcanvasdiv, >>>>>>> lzcanvasclickdiv >>>>>>> and lzcanvascontextdiv CSS declarations. Ensure >>>>>>> lzcanvasclickdiv qnd >>>>>>> lzcanvascontextdiv have a width and height so overflow: hidden >>>>>>> doesn't >>>>>>> hide clickable areas. >>>>>>> >>>>>>> Tests: See LPP-8402, also try calendar with ?lzr=dhtml&lzt=html >>>>>>> in one >>>>>>> of the affected browsers. >>>>>>> >>>>>>> Files: >>>>>>> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js >>>>>>> M WEB-INF/lps/templates/html-response.xslt >>>>>>> >>>>>>> Changeset: >>>>>>> http://svn.openlaszlo.org/openlaszlo/patches/20090821-maxcarlson-Y.tar >>>>>>> _______________________________________________ >>>>>>> Laszlo-reviews mailing list >>>>>>> [email protected] >>>>>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >>>>> -- >>>>> Regards, >>>>> Max Carlson >>>>> OpenLaszlo.org >>>>> _______________________________________________ >>>>> Laszlo-reviews mailing list >>>>> [email protected] >>>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >>> -- >>> Regards, >>> Max Carlson >>> OpenLaszlo.org >>> _______________________________________________ >>> Laszlo-reviews mailing list >>> [email protected] >>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
-- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
