I'm not sure I understand what is going on here. Why do we change the z-order of the root when we are just looking to see if there is a context menu item to display? I would think if we needed to do any of this hijinx, it would be when you actually display the context menu. Maybe we just don't need this quirk any more? Or is it really that we just need to turn off globalClickable when we are searching for the context menu, in which case we should use that.
I think we need input from Max on this. On 2009-08-25, at 17:38EDT, Henry Minsky wrote: > Note: there's a regression I'm looking at (LPP-8421) which causes > the default canvas context menu not to appear if you click > right on the canvas. That's independent of this change. > > > Change 20090825-hqm-h by [email protected] on 2009-08-25 17:34:30 EDT > in /Users/hqm/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: fix for flickering swfs when right click menu is opened > > New Features: > > Bugs Fixed: LPP-8405 > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > > + when a right click is handled, instead of hiding the canvas > content and click divs, > we set their z-order to negative values, to place them behind the > contextmenu click div. > > > Tests: > > + test case from bug report, does not flicker. > + test/contextmenu/lpp-6980.lzx , check that proper context menu > shows up, regardless of whether other > opaque views are layered on top, check that embedded swf in <html> > tag does not flicker when > context menu is opened > > Files: > M test/contextmenu/lpp-6980.lzx > M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js > > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090825-hqm-h.tar _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
