On 8/25/2009 8:29 PM, P T Withington wrote: > getQueryArg is a nice simplification. Why do you declare it as a var, > rather than just an inner function?
Ok, replaced it with an inner function. > As to hasfgcolor, ok, because that is apparently the way things are > done, but perhaps you should file an improvement to make the text > property inheritance more sane? Maybe we already have a relevant bug > regarding inheriting properties that have CSS bindings? The hasfgcolor-flag doesn't really work properly, if just created LPP-8422. So that needs to be changed anyway. > Approved. > > On 2009-08-24, at 18:48EDT, André Bargull wrote: > >> Change 20090825-bargull-Zic by barg...@dell--p4--2-53 on 2009-08-25 >> 00:23:11 >> in /home/Admin/src/svn/openlaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: make fgcolor from canvas work for text / improve initial >> argument handling in canvas >> >> New Features: >> >> Bugs Fixed: LPP-8377 (default foreground-color specified on canvas >> doesn't work), LPP-8414 (SWF9: enabling "history" throws >> "ReferenceError") >> >> Technical Reviewer: ptw >> QA Reviewer: (pending) >> Doc Reviewer: (pending) >> >> Documentation: >> >> Release Notes: >> >> Details: >> LPP-8377: set 'hasfgcolor' so lz.text accepts 'fgcolor' from canvas >> LPP-8414: make initial arguments processing more uniform for >> 'accessible', 'history', 'allowfullscreen' and 'proxied' (see >> getQueryArg() function). The ReferenceError was thrown in swf9, >> because the entry for 'history' wasn't deleted from the "args"-object, >> this is now handled in getQueryArg(). >> >> >> Tests: >> testcases from bugreport >> >> Files: >> M WEB-INF/lps/lfc/views/LaszloCanvas.lzs >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20090825-bargull-Zic.tar >> > > _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
