I'd like to have a policy in the JS kernel that properties that do not
need to be visible on every instance go on the constructor (more like
a static var).
Some day, I'd like to rewrite the JS kernel using our classes. I
think keeping it in pure JS has been more of a trouble than a benefit,
since we know our compiler will translate into pure JS.
On 2009-09-04, at 05:52, André Bargull wrote:
>> /**
>> * @access private
>> + * tracks whether the mouse is currently down on this sprite for
>> onmouseupoutside events
>> */
>> -LzSprite.prototype.__mouseEvent = function ( e , artificial){
>> +LzSprite.__mouseisdown = false;
>
> "__mouseisdown" should go on the prototype, shouldn't it? Otherwise
> approved.
>
>
> On 9/3/2009 9:25 PM, Max Carlson wrote:
>> Change 20090902-maxcarlson-A by maxcarl...@bank on 2009-09-02
>> 14:54:33 PDT
>> in /Users/maxcarlson/openlaszlo/trunk-clean
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Fix context menu events on OS X
>>
>> Bugs Fixed: LPP-8423 - DHTML: two global onmouseup events for each
>> click
>>
>> Technical Reviewer: [email protected]
>> QA Reviewer: hminsky
>>
>> Details: LzSprite - Don't process events with button == 2 - allow
>> them
>> to be processed by global mouse event handlers. Bubble global
>> mouseup
>> for onmouseup/onmouseupoutside events. Improve comments around mouse
>> handling.
>>
>> LzMouseKernel - Improve comments. Make button==2 handling explicitly
>> part of context menu handling. Simplify contextmenu menu hiding
>> logic
>> in __sendEvent(). Explicitly skip bubbled onmouseup events in
>> __mouseupEvent(). Use LzSprite.__rootSprite instead of
>> canvas.sprite...
>>
>> Tests: test/contextmenu/lpp-6980.lzx?lzr=dhtml and testcase from
>> LPP-8423 pass in OS X and Windows Firefox 3.5
>>
>> Files:
>> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>> M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20090902-maxcarlson-
>> A.tar
>>
> _______________________________________________
> Laszlo-reviews mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
