Approved! P T Withington wrote: > [Still waiting for your official review on this, so I can close the bug...] > > [I'm going to check this in ahead of review, because it is breaking all > non-debug dhtml code.] > > On 2009-09-03, at 22:48, P T Withington wrote: > >> Change 20090903-ptw-F by [email protected] on 2009-09-03 22:44:11 EDT >> in /Users/ptw/OpenLaszlo/trunk-2 >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Ensure debug and profile bits are in appropriate conditionals >> >> Bugs Fixed: LPP-8431 IE7 DHTML getting global properties clobbered >> >> Technical Reviewer: max (pending) >> QA Reviewer: hminsky (pending) >> >> Details: >> Class was referring to bits that would not be in non-debug >> builds. Profile builds depend on a few Debug constants, so make >> sure those are available. >> >> Tests: >> smokecheck in dhtml for plain, debug, and profile all load without >> Firebug errors. >> >> Files: >> M WEB-INF/lps/lfc/debugger/stubs.lzs >> M WEB-INF/lps/lfc/compiler/LzRuntime.lzs >> A WEB-INF/lps/lfc/compiler/LzDebugStub.lzs >> M WEB-INF/lps/lfc/compiler/Library.lzs >> M WEB-INF/lps/lfc/compiler/Class.lzs >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20090903-ptw-F.tar >
-- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
