I'm confused as to how this is working.  You're turning off overflow  
hidden, but when you have a text element with a set width, you want it  
to clip the content, so, I guess you are turning hidden back on?  But  
I don't understand how the __wpadding came back into play, since it  
has been off for a long time.  I thought that it was covered by the  
padding in the CSS style combined with the overflow setting?

I guess I'm concerned that this change could affect a lot of other  
delicately balanced things...

On 2009-10-08, at 05:01, Max Carlson wrote:

> Change 20091008-maxcarlson-o by [email protected] on 2009-10-08
> 01:52:39 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: UPDATED AGAIN: Turn off overflow: hidden for non-multiline
> DHTML text
>
> Bugs Fixed: LPP-8399 - Drop-shadow support for DHTML runtime, LPP-8538
> -  DHTML: text with set width appears different from swf
>
> Technical Reviewer: hminsky
> QA Reviewer: [email protected]
>
> Details: LzSprite - Remove overflow:hidden style defaults for text.
> Remove unneeded lztextcontainer_click style.
>
> LzTextSprite - Overflow: hidden should only be needed for multiline
> fields, fields with resize=false, or those with scrollEvents on.
> Explicitly turn off overflow: hidden when shadows are turned on.
> Correct sizing of widths to visually match Flash.
>
> Tests: test/dropshadow.lzx no longer clips in DHTML.  test/lztest/
> lztest-textheight.lzx runs as before.  Testcase from LPP-8538 now
> looks consistent in swf and dhtml.
>
> Files:
> M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M       WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20091008-maxcarlson-o.tar
> _______________________________________________
> Laszlo-reviews mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to