This comment seems misplaced: > this.tsprite.setScrollEvents(on); > + // Warn if user has <text> view with scrollevents=true, but which > does not have clipping enabled (LPP-8562) > if (this.onscrollevents.ready) this.onscrollevents.sendEvent(on);
And in your warning messages, your should probably say `clip="true"` instead of `clip=true`. Otherwise, approved. On 2009-10-21, at 12:19, Henry Minsky wrote: > updated with ptw's suggestion for checking scrollevents/clip flag at > init time > > > Change 20091021-hqm-u by [email protected] on 2009-10-21 12:15:33 EDT > in /Users/hqm/openlaszlo/trunk6 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: add warning about clip and scrollevents, make clipping > runtime settable > > New Features: > > Bugs Fixed: LPP-8562 > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > > + LzText: put in warning when LzText has scrollevents=true but > clip=false > + LzView: add setter and onclip event for the 'clip' attribute > > + cleanup of vestigial scrolling code in swf kernel (must have gotten > copied over when > the sprite was originally forked from LzText) > > Tests: > > + warning for non-clipped text view: > <canvas height="80%"> > <text x="100" y="50" name="tField" multiline="true" width="300" > height="100" scrollevents="true"/> > <inputtext x="500" y="50" name="ifield" multiline="true" > width="300" height="100" scrollevents="true"/> > </canvas> > > warning should print in debugger about 'clip' needing to be set for > the first text view. > > > + test that you canset clip attribute at runtime > <canvas height="80%"> > <view bgcolor="#cccccc" width="100" height="100" clip="true" > id="v1"> > <handler name="onclick"> > this.setAttribute('clip', !this.clip); > </handler> > <text text="${'clip: '+parent.clip}"/> > <view bgcolor="red" width="500" y="40" height="20"/> > </view> > </canvas> > > > Files: > M WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as > M WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as > M WEB-INF/lps/lfc/views/LzText.lzs > M WEB-INF/lps/lfc/views/LaszloView.lzs > M lps/components/debugger/newcontent.lzx > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091021-hqm-u.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
