The bug was that the updateSchema pass was descending into <doc> comments !
On Fri, Dec 4, 2009 at 4:48 PM, Henry Minsky <[email protected]> wrote: > Oops, there's something causing an error in smokecheck now > > lzunit/lzunit.lzx:838:310: The classname attribute, "name" must be a valid > identifier for a class definition > > I'll send another changeset when I figure that out... > > On Fri, Dec 4, 2009 at 4:45 PM, Henry Minsky <[email protected]>wrote: > >> Change 20091204-hqm-g by [email protected] on 2009-12-04 10:17:09 EST >> in /Users/hqm/openlaszlo/trunk6 >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: fix for instance-mixin fails for non-top-level instance >> >> New Features: >> >> Bugs Fixed: LPP-8654 instance-mixin fails for non-top-level instance >> >> Technical Reviewer: ptw >> QA Reviewer: max >> Doc Reviewer: (pending) >> >> Documentation: >> >> Release Notes: >> >> Overview: >> >> >> Details: >> >> + ViewCompiler: updateSchema recursively map over child elements >> >> + ClassModel: remove code in ClassModel that inserted a classdef into the >> DOM. >> >> + ScriptClass: added a "kind" field >> >> + updated lztest smoke check for mixins to have non-toplevel node with >> mixin >> >> Tests: >> >> test case from bug >> test/mixins.lzx >> smokecheck >> test/smoke/mixin-simple.lzx >> >> >> Files: >> M test/lztest/lztest-mixins.lzx >> M WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptClass.java >> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewCompiler.java >> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java >> >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20091204-hqm-g.tar >> > > > > -- > Henry Minsky > Software Architect > [email protected] > > > -- Henry Minsky Software Architect [email protected]
_______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
