You can safely revert the .pngs (except dev-console.sprite.png). They are being re-composited by the compiler but don't need to be. Otherwise, approved!
This takes care of all the issues I was seeing. Memory usage does seem higher though... Not sure what we can do until Safari is fixed and a new version released. On 1/10/10 3:00 PM, P T Withington wrote: > [This works around the Safari bug, at a minor cost. I think we have to do > it, but it is a bit of a kludge. > > Max, any idea why recompiling the console results in all the .png's being > changed?] > > Change 20100110-ptw-K by [email protected] on 2010-01-10 17:43:37 EST > in /Users/ptw/OpenLaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Work-around for Safari bug #33450 > > Bugs Fixed: LPP-8626 Regression: > examples/components/component_sampler.lzx?lzr=dhtml&lzt=html crashes > Safari 4.0.4 OS X > > Technical Reviewer: max (pending) > QA Reviewer: hminsky (pending) > > Overview: > Kludge DHTML back-end to rewrite a.b as a['b'] to work around > Safari bug. Recompile the console. > > Tests: > smokecheck, test cases from bug, dhtml console buttons no longer > collide, ant lztest. > > Files: > M WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java > M lps/admin/dev-console.lzx.js > M lps/admin/dev-console.sprite.png > M lps/admin/dev-console.lzx.swf > M > lps/admin/lps/resources/lps/components/lz/resources/focus/focus_top_lft_shdw.sprite.png > M > lps/admin/lps/resources/lps/components/lz/resources/checkbox/autoPng/checkbox_off.sprite.png > M > lps/admin/lps/resources/lps/components/lz/resources/button/simpleface_up.sprite.png > M > lps/admin/lps/resources/lps/components/lz/resources/autoPng/bezel_inner_up.sprite.png > M > lps/admin/lps/resources/lps/components/lz/resources/autoPng/bezel_outer_up.sprite.png > M > lps/admin/lps/resources/lps/components/lz/resources/radio/autoPng/radiobtn_up.sprite.png > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100110-ptw-K.tar -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
