I would find it more understandable if the local variable were named "invisible", since that is what it is looking for: are any of my parents invisible?
I wonder if a better way to handle this quirk would be if we noticed when a sprite became visible (is there a DOM attache event?) and then walked its children and assigned their sizes? If there's no chance of that, then approved as is. On 2010-01-11, at 16:56, Max Carlson wrote: > Change 20100109-maxcarlson-K by maxcarl...@bank on 2010-01-09 16:10:52 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED IE DHTML: Update size of dynamically loaded images correctly > > Bugs Fixed: LPP-8182 - OL4.4: Lzproject can not display correctly after login > for IE7 browser and DHTML runtime (partial) > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: Handle case where an invisible parent can't be shown because it's > not attached into the DOM yet. Use timeouts (with a limit of 20 tests) > instead of waiting for canvas init time, so image sizes can be corrected > later - like in the case in LzPix Henry ran into. Improve performance of > __isMouseOver() testing. > > Tests: 'Show Flash' button appears in the correct place after login for IE > DHTML. LzPix DHTML runs as before. > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100109-maxcarlson-K.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
