Hang on a sec, I am getting an error in smokecheck. Blast. On 2010-01-12, at 19:02, Max Carlson wrote:
> Approved! This seems to fix the issue in Safari 4.0.4. I don't see any > issues in webkit nightlies, and IE DHTML works again with backtraces. > > On 1/12/10 3:12 PM, P T Withington wrote: >> [I'm going to check this into trunk so you can test it. If it works, then I >> will integrate it to branches/4.7. Max could you verify that this makes >> "IE7 DHTML with backtrace enabled, I get errors accessing a 'length' >> property of an object" go away?] >> >> Change 20100112-ptw-M by [email protected] on 2010-01-12 16:05:03 EST >> in /Users/ptw/OpenLaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Less intrusive workaround for WebKit bug 32402 >> >> Bugs Fixed: LPP-8626 Regression: >> examples/components/component_sampler.lzx?lzr=dhtml&lzt=html crashes >> Safari 4.0.4 OS X >> >> Technical Reviewer: max (pending) >> QA Reviewer: hminsky (pending) >> >> Overview: >> On the broken version of Safari only, the class substrate will >> install the class default values directly in the instance rather >> than only in the prototype. >> >> Details: >> Class.lzs: In the broken Safari version only, add a special >> 'pre-initializer' method to install the class defaults on each >> instance. >> >> ParseTreePrinter.java: Revert r15423. Write out property accesses >> normally. >> >> Recompile the dev console. >> >> Tests: >> smokecheck, ant lztest, both test cases from the bug, the >> recompiled console displays correctly >> >> Files: >> M WEB-INF/lps/lfc/compiler/Class.lzs >> M WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java >> M lps/admin/dev-console.lzx.js >> M lps/admin/dev-console.sprite.png >> M lps/admin/dev-console.lzx.swf >> >> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100112-ptw-M.tar > > -- > Regards, > Max Carlson > OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
