On Jan 19, 2010, at 6:45 AM, P T Withington <[email protected]> wrote: > You made this change in 4.0. Does that imply we expect to make > another 4.0 release? I thought we were done with that. Apparently not... Webtop still has releases under 4.0. I'm not sure if an official release is required - they seemed happy deploying on a nightly build before... > In any case, it looks like the same bug exists in trunk (and should > be fixed there first). Then we figure out if it merits integrating > and making point releases on any branches... Agreed - I'm trying to reproduce the issue in trunk as we speak. > Is the bug that there is no `Lz[iframe.owner]` or that > `iframe.owner` is null? I'm confused by the logic here. > > > On 2010-01-18, at 23:54, Max Carlson wrote: > >> Change 20100118-maxcarlson-i by [email protected] on 2010-01-18 >> 21:52:59 MST >> in /Users/maxcarlson/openlaszlo/pagan-deities >> for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities >> >> Summary: Add test to prevent null dereferencing in iframemanager >> >> Bugs Fixed: LPP-8722 - javascript error in iframemanager.js when >> prompted to upgrade the flash player. >> >> Technical Reviewer: ptw >> QA Reviewer: mdemmon >> >> Details: Add a test to prevent null dereferencing of the property Lz >> [iframe.owner]. >> >> Tests: See LPP-8722 >> >> Files: >> M lps/includes/source/iframemanager.js >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20100118-maxcarlson-i.tar >> >> _______________________________________________ >> Laszlo-reviews mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews > _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
