The patch appears to work. -Maynard
Max Carlson wrote: > Cool. Can you review my latest patch for trunk? Thanks! > > > > On Jan 21, 2010, at 4:20 PM, Maynard Demmon <[email protected]> > wrote: > >> I figured out the problem. The patch you sent for iframemanager.js was >> from jade not pagan-deities. After removing your patch and svn up to >> latest things seem to work. >> >> -Maynard >> >> Max Carlson wrote: >>> These are in pagan-deities, right? Those line numbers don't match >>> what I'm seeing in trunk. Also, what revision are you using now? If >>> you have the revision of the older file that would be helpful. Thanks! >>> Regards, >>> Max Carlson >>> OpenLaszlo.org >>> On 1/20/10 1:09 PM, Maynard Demmon wrote: >>>> I'm also getting some odd errors trying to run webtop that I think are >>>> related to other recent changes to embed-compressed.js. >>>> >>>> Specifically, I get: >>>> >>>> lz is not defined >>>> embed-compressed.js()embed-...ssed.js (line 474) >>>> [Break on this error] }}}}};dojo.flash.info=new >>>> (dojo.flash....},create:function($1,$2,$3,$4,$5,$6){ >>>> embed-...ssed.js (line 474) >>>> >>>> >>>> Lz.history is undefined >>>> swfEmbed()embed-...ssed.js (line 21) >>>> writeApp()webtop.js (line 200) >>>> lzmail-greengold?debug=true()lzmail...ug=true (line 215) >>>> [Break on this error] $9._onload.push(Lz.history.init) >>>> embed-...ssed.js (line 21) >>>> >>>> I diffed this most recent embed-compressed to a prior one I still had >>>> sitting around and there were significant differences. >>>> >>>> -Maynard >>>> >>>> >>>> >>>> P T Withington wrote: >>>>> This appears to have an extra `!` and a missing `]`: >>>>> >>>>> + if (! lz.embed[iframe.owner) { >>>>> + >>>>> lz.embed[iframe.owner].callMethod('lz.embed.iframemanager.__gotload(\'' >>>>> + >>>>> id + '\')'); >>>>> >>>>> On 2010-01-19, at 15:53, Max Carlson wrote: >>>>> >>>>>> Change 20100119-maxcarlson-o by [email protected] on 2010-01-19 >>>>>> 13:52:28 MST >>>>>> in /Users/maxcarlson/openlaszlo/trunk-clean >>>>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>>>> >>>>>> Summary: Add test to prevent null dereferencing in iframemanager >>>>>> >>>>>> Bugs Fixed: LPP-8722 - javascript error in iframemanager.js when >>>>>> prompted to upgrade the flash player. >>>>>> >>>>>> Technical Reviewer: ptw >>>>>> QA Reviewer: mdemmon >>>>>> >>>>>> Details: Add a test to prevent null dereferencing of the property >>>>>> Lz[iframe.owner]. >>>>>> >>>>>> Tests: See LPP-8722 >>>>>> >>>>>> Files: >>>>>> M lps/includes/source/iframemanager.js >>>>>> >>>>>> Changeset: >>>>>> http://svn.openlaszlo.org/openlaszlo/patches/20100119-maxcarlson-o.tar >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Laszlo-reviews mailing list >>>>>> [email protected] >>>>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >>>>> >>>> >>>> >> >> _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
