approved! 2010/1/22 Max Carlson <[email protected]>
> Change 20100113-maxcarlson-h by maxcarl...@bank on 2010-01-13 11:05:24 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: FIFTIETH TIME IS THE CHARM: Optimize LzNode > > Bugs Fixed: LPP-8716 - Improved LzNode startup time > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: Per Andre's comments, use -1 as a sentinel value for fake setters > - eliminate all references to __LZdelayedSetters. Per Tucker's comments, > add __LZresolveOtherReferences() method to do layout setting in the right > place - after init, contraints, but _before_ delegates. Pass > __LZresolveDict arg to __LZresolveOtherReferences(), as it's nulled out > above. > > LzNode - Check for presence of __LZresolveDict before installing computed > initializations (could save a function call). Explicitly test for read-only > setters in __LZapplyArgs() (testing '!= -1' should be faster than 'is > Function'). In __LZresolveReferences(), install layouts explicitly and > comment out generalized loop, formerly used for backward compatibility > (should be much faster). Call __LZresolveOtherReferences() if present, to > allow subclasses to resolve references, e.g. layout in LaszloView. > > LaszloView - Implement __LZresolveOtherReferences() to deal with layout > attribute/setter. > > LaszloCanvas, LaszloView - Remove unused __LZdelayedSetters assignment. > > Tests: All apps run as before, including smoketest. > > Files: > M WEB-INF/lps/lfc/core/LzNode.lzs > M WEB-INF/lps/lfc/views/LaszloView.lzs > M WEB-INF/lps/lfc/views/LaszloCanvas.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100113-maxcarlson-h.tar > -- Henry Minsky Software Architect [email protected]
_______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
