Not approved yet: 1) I don't buy the copying of the tooltip code into the debug window. a) If you don't rename it, it's going to collide with any app that includes the component tooltip; b) doesn't the debugger already use other components? If you really want to insulate the debug window from the app, it needs to be solo compiled and run in a separate (floating?) iframe, like the console.
2) You and Max need to resolve how the multi-frame resources are really supposed to work, which should be a separate bug, not papered-over with this change. 3) I guess I approve adding the bugReport button for show, but we really need a better way, because you have to first select the error you want to report before you can really just push the button... I think we are rushing this out to get a "screen shot" for OL <view> and we should instead make a more vanilla shot of using bugReport from the command line and think this whole idea through more carefully. On 2010-01-25, at 11:28, Henry Minsky wrote: > Change 20100125-hqm-E by [email protected] on 2010-01-25 11:24:21 EST > in /Users/hqm/openlaszlo/trunk6 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: update some buttons in the debug window > > New Features: > > Bugs Fixed: > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > + Added a bug-report button to main debugger window > + Added tooltips > + Updated button resources to use pngs so they animate properly in swf10 > runtime > > > Details: > > + debugger.lzx: explicitly declare multiframe resources for buttons, so the > flash10 compiler can > compile multiframe resources from .png files > > + added tooltips, but made a copy of tooltip code from incubator, to keep > debugger somewhat > self contained. > > > > Tests: > > + mouse over buttons in debugger, see tooltips > > + in swf10, mouse over / click on buttons in debugger shows proper resource > frames > > Files: > M lps/components/debugger/debugger.lzx > M lps/components/debugger/newcontent.lzx > A lps/components/debugger/tooltipview.lzx > A lps/components/debugger/images/tooltip_pointer_up.png > A lps/components/debugger/images/tooltip_pointer_dn.png > A lps/components/debugger/images/buttons/autoPng/bug0001.png > A lps/components/debugger/images/buttons/autoPng/bug0002.png > A lps/components/debugger/images/buttons/autoPng/bug0003.png > A lps/components/debugger/tooltip.lzx > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100125-hqm-E.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
