Approved! That's pretty crazy... I do think this should be merged to 4.7.1.
Regards, Max Carlson OpenLaszlo.org On 2/10/10 3:58 PM, P T Withington wrote: > Wow! Very tricky bug. (Amusing that objectOwnProperties tries to protect > itself from getters failing on prototypes, but in this case the prototype has > to protect itself.) > > Max: You added the offending getter in -r14795. This seems like the right > fix to me, but I'd like your approval too. Also, if you think this should be > merged to 4.7.1 > > I approve if Max does. > > On 2010-02-10, at 18:28, André Bargull wrote: > >> Change 20100211-bargull-7mc by barg...@dell--p4--2-53 on 2010-02-11 00:15:06 >> in /home/Admin/src/svn/openlaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: make leak detector working again (swf8) >> >> Bugs Fixed: LPP-8581 (SWF8: Leak detector does not work anymore) >> >> Technical Reviewer: ptw >> >> Details: >> Accessing"isaudio" on LzSprite.prototype invokes the >> "isaudio" getter, which in turn called a couple of functions >> on the prototype. This made the prototype itself invalid and broke the >> complete application. >> The fix simply checks whether the context is an instance of LzSprite, if >> the check fails the getter returns'undefined'. >> >> >> Tests: >> - testcase from bugreport >> - Debug.objectOwnProperties(..) works for LzSprite.prototype >> >> Files: >> M WEB-INF/lps/lfc/kernel/swf/LzSprite.as >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20100211-bargull-7mc.tar >> >> _______________________________________________ >> Laszlo-reviews mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews > _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
