Approved if you will put the 8707 in the comment in LzSprite.
I'm curious though, about this stretch of code:
> // Safari 3.x does not send global key events to apps embedded in
> an iframe
> // no longer true for 3.0.4 - see LPP-8355
> if (browser.version < 523.15) {
> quirks['keyboardlistentotop'] = true;
> }
> // Safari 4 needs help to get keyboard events when loaded in a
> frame - see LPP-
> if (window.top !== window) {
> quirks['keyboardlistentotop_in_frame'] = true;
> }
The comment seems to indicate that we thought the bug was fixed in 3.something
and now it is back?
On 2010-02-12, at 14:11, Max Carlson wrote:
> Change 20100212-maxcarlson-a by maxcarl...@bank on 2010-02-12 11:02:21 PST
> in /Users/maxcarlson/openlaszlo/trunk-clean
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix keyboard focus in Safari when loading in a frame
>
> Bugs Fixed: LPP-8707 - OL 4.7.X - DHTML - SAF4 - Components - Button - Tab
> key can not work at all
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: LzKeyboardKernel - Track the last scope keyboard events were
> registered for and unregister them as needed, since keyboardlistentotop can
> change.
>
> LzSprite - Add keyboardlistentotop_in_frame quirk, set to true in Safari.
> When keyboardlistentotop_in_frame is true, listen for window focus events,
> and send a mouseover/activation event. Also, set the keyboardlistentotop
> quirk to true, and register for globak keyboard events, unless
> options.cancelkeyboardcontrol is true.
>
> index.jsp - Use master sprite and cancel keyboard events for the navigation
> app.
>
> Tests: See LPP-8708 in DHTML.
>
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M laszlo-explorer/index.jsp
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20100212-maxcarlson-a.tar
>
> _______________________________________________
> Laszlo-reviews mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
