Oh now I remember, there  was an issue if you are importing a library which
is above your app home dir, you want to make a subdirectory to put the
compiled files in, otherwise you are not assured of being able to get them
at runtime.



On Fri, Feb 12, 2010 at 11:33 PM, Henry Minsky <[email protected]>wrote:

> I guess we can put the compiled libraries next to the corresponding source
> .lzx file.
> I can't remember  now why we used a subdirectory to store them.
>
>
>
> On Fri, Feb 12, 2010 at 10:39 PM, Max Carlson <[email protected]>wrote:
>
>> Maybe 'library' but that's not much better.  Why can't the libraries be
>> placed along their sources - in the same path?
>>
>>
>> On 2/12/10 7:10 PM, Henry Minsky wrote:
>>
>>> OK do you have a suggested name ?
>>>
>>>
>>>
>>> On Fri, Feb 12, 2010 at 9:40 PM, Max Carlson <[email protected]
>>> <mailto:[email protected]>> wrote:
>>>
>>>    One thing: could we make the 'build' directory have a more specific
>>>    name?  I wasn't sure at first where it came from!  We could also
>>>    place the libraries alongside where they came from, instead of
>>>    placing them in their own build folder...
>>>
>>>    Otherwise, approved!
>>>
>>>
>>>    On 2/12/10 6:26 PM, Henry Minsky wrote:
>>>
>>>        added missing file
>>>
>>>
>>>        Change 20100212-hqm-k by [email protected] on 2010-02-12
>>>        17:08:20 EST
>>>             in /Users/hqm/openlaszlo/trunk-clean
>>>             for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>>        Summary: fix for swf9 dynamic libraries
>>>
>>>        New Features:
>>>
>>>        Bugs Fixed: LPP-8727 bug in dynamically loaded library in swf9/10
>>>
>>>        Technical Reviewer: ptw
>>>        QA Reviewer: max
>>>        Doc Reviewer: (pending)
>>>
>>>        Documentation:
>>>
>>>        Release Notes:
>>>
>>>        Overview:
>>>
>>>        Removed CompilationEnvironment instance var from ClassModel.
>>>
>>>        Pass compilation environment in from ImportCompiler to
>>>        ClassModel, so that classes are
>>>        emitted into the correct output stream
>>>
>>>
>>>        Details:
>>>
>>>        I missed a case in the last patch, for NodeModel.asMap which
>>>        calls emitClassDeclaration
>>>
>>>        NodeModel.java:
>>>           +  Pass CompilationEnvironment arg to
>>>        ClassModel.emitClassDeclaration
>>>
>>>        ClassModel.java:
>>>        +  Add CompilationEnvironment arg to getNodeModel
>>>
>>>        + Pass CompilationEnvironment arg to getNodeModel
>>>
>>>        Other files had to be changed to add extra env arg to
>>>        NodeModel.asMap()
>>>
>>>
>>>        Tests:
>>>
>>>        + test case from bug report, in swf10, swf8, dhtml
>>>        + smokecheck
>>>        + test/snippets/import-view
>>>        + test/snippets/import-class-and-view-direct
>>>
>>>
>>>        Files:
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewCompiler.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/ImportCompiler.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/DebugCompiler.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/SplashCompiler.java
>>>        M
>>>        WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
>>>
>>>        Changeset:
>>>        http://svn.openlaszlo.org/openlaszlo/patches/20100212-hqm-k.tar
>>>
>>>
>>>    --
>>>    Regards,
>>>    Max Carlson
>>>    OpenLaszlo.org
>>>
>>>
>>>
>>>
>>> --
>>> Henry Minsky
>>> Software Architect
>>> [email protected] <mailto:[email protected]>
>>>
>>>
>>>
>> --
>> Regards,
>> Max Carlson
>> OpenLaszlo.org
>>
>
>
>
> --
> Henry Minsky
> Software Architect
> [email protected]
>
>
>


-- 
Henry Minsky
Software Architect
[email protected]
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to