I don't understand the motivation for this change. I thought we had the warnings down to when you really needed them. Is there a test case?
It the warnings really are useless, I'd rather disable them altogether than add yet another flag (that no one will ever know to turn on). But since this feature was requested by the previous components designer, I'd like to understand better why it is not working before we just do that. On 2010-02-17, at 13:45, Max Carlson wrote: > Change 20100217-maxcarlson-1 by maxcarl...@bank on 2010-02-17 10:19:35 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Add option to disable CSS warnings > > New Features: Canvas now has a 'showcsswarnings' option, which defaults to > false. If true, 'No applicable value for CSS property %w and there is no > default.' warnings will be shown. > > Bugs Fixed: LPP-8772 - Add option to disable 'No applicable value for CSS > property %w and there is no default.' warnings > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Release Notes: Canvas now has a 'showcsswarnings' option, which defaults to > false. If true, 'No applicable value for CSS property %w and there is no > default.' warnings will be shown. > > Details: LzNode - Don't warn unless canvas.showcsswarnings is true. > > LaszloCanvas - Add showcsswarnings property and setter. > > Tests: See LPP-8772 > > Files: > M WEB-INF/lps/lfc/core/LzNode.lzs > M WEB-INF/lps/lfc/views/LaszloCanvas.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100217-maxcarlson-1.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
