Approved.
This:
> if (!options.getBoolean(Compiler.DEBUG_EVAL)) {
> if (!options.getBoolean(Compiler.REUSE_WORK_DIRECTORY)) {
> if (options.getBoolean(Compiler.INCREMENTAL_COMPILE)) {
is getting awfully hairy. I hope we can make it more sensible some day...
On 2010-03-08, at 17:24, Henry Minsky wrote:
> Change 20100308-hqm-C by [email protected] on 2010-03-08 17:16:24 EST
> in /Users/hqm/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: fix swf10 debugger eval
>
> New Features:
>
> Bugs Fixed: LPP-8633
>
> Technical Reviewer: ptw
> QA Reviewer: max
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Overview:
>
> This doesn't fix LPP-8633, but the swf10 debug eval feature go rotted
> in a couple of places, so this gets us back to where we can work the
> original bug.
>
> Details:
>
> Compiler.java: remove 'incremental' compile flag, it just messes up the flex
> compile
>
> LzFlashRemote.as, eval.lzx: we were sticking an extra ".lzx" on the pathname,
> causing the compiler to use the
> wrong working directory
>
> SWF9External: make sure not to clean out the working directory when you are
> compiling a debug-eval
> expression, otherwise you can't link against the main app.
>
> Tests:
>
> test/hello.lzx?lzr=swf10&debug=true
>
> + make sure you can eval several expressions that require server side
> compilation, such as 2+2, 3+3, etc
>
> + Make an eval of an expression with a compiler error, such as
> "foo".blahblah() and see that
> a proper error message is printed to the debugger console
>
>
> Files:
> M WEB-INF/lps/lfc/debugger/platform/swf9/LzFlashRemote.as
> M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
> M lps/components/debugger/platform/swf9/eval.lzs
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100308-hqm-C.tar
>
> _______________________________________________
> Laszlo-reviews mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
