I think you need to update "LzText.fontArgToAttr", now that "fontname"
is removed. ("LzText.fontArgToAttr" was only used to map from "fontname"
to "font").
And the documentation for LzView#font needs to be updated, currently it
says updates are not cascaded at runtime, but this change modifies this
behaviour:
* [...] When the font attributes are modified at runtime,
* using JavaScript, the font is changed for the view itself, not
* for any of its subviews.
- this.__LZresolveReferences();
+ // Is it even possible for there to be a canvas resolve dict?
+ if (this.__LZresolveDict != null) this.__LZresolveReferences();
What about constraints or handlers? In that case, canvas has got a
resolve dict, doesn't it?
On 3/25/2010 7:31 PM, Max Carlson wrote:
Change 20100325-maxcarlson-v by maxcarl...@bank on 2010-03-25 11:20:34 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Make dynamic text register for changes to parent font/size/style
attributes
Bugs Fixed: LPP-8376 - Font attributes from stylesheets do not cascade from
parent views to child text nodes (partial)
Technical Reviewer: ptw
QA Reviewer: hminsky
Details: LzText - Register for updates to font/size/style attributes when
compiler doesn't supply font information.
LaszloView - Remove redundant fontname attribute, clean up docs
LaszloCanvas - Update canvas attribute spec, update comments, don't call
__LZresolveReferences() unless necessary.
CanvasCompiler - Pass canvas font in via 'font' attribute instead of 'fontname'.
Tests: See LPP-8376 - testcase now works for dynamically created text.
Files:
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100325-maxcarlson-v.tar
