Approved! On 3/29/10 8:57 AM, P T Withington wrote:
Change 20100326-ptw-A by [email protected] on 2010-03-26 18:48:28 EDT in /Users/ptw/OpenLaszlo/trunk for http://svn.openlaszlo.org/openlaszlo/trunkSummary: Turn off optimizations that generate broken Javascript Bugs Fixed: LPP-8849 Nonsensical compiler warning 'No prec for ASTEmptyExpression in...' `for a simple typo Technical Reviewer: hminsky (pending) QA Reviewer: max (pending) Overview: Turn off putative optimization that results in generating invalid Javascript. Details: JavascriptGenerator: Conditionalize all 'dead expression' elimination with the compiler option (which is off for now). *Generator: Generate slightly more compact unique names. ParseTreePrinter: Turn CompilerExceptions into more informative CompilerErrors. Remove the backtrace output and signal an exception for the `prec` function failing. Tests: Test case from bug report no longer causes the compiler to emit the nonsensical warning. Files: M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java M WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java M WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100326-ptw-A.tar
-- Regards, Max Carlson OpenLaszlo.org
