Oooh good catch once again, André. Thanks!
Regards,
Max Carlson
OpenLaszlo.org
On 4/1/10 8:57 AM, André Bargull wrote:
@@ -737,7 +732,7 @@
* @type Number
* @lzxdefault 0
*/
-var fgcolor = 0;
+var fgcolor = null;
/** true if the view specified a fgcolor
@access private */
var hasfgcolor = false;
'hasfgcolor' definition should also be removed, shouldn't it?
Otherwise approved.
On 4/1/2010 6:03 AM, Max Carlson wrote:
Change 20100331-maxcarlson-8 by maxcarl...@bank on 2010-03-31 20:53:21
PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix text color assignment
Bugs Fixed: LPP-8422 - default foreground-color for text doesn't work
if set on onconstruct
Technical Reviewer: [email protected]
QA Reviewer: hminsky
Details: swf/LzTextSprite - Set text color in __initTextProperties().
Rename setColor() -> setTextColor(). Remove getColor().
swf/LzSprite - Remove setColor(), getColor().
dhtml/LzSprite - Remove warning about color cascading, setColor().
dhtml/LzTextSprite - Set text color in __initTextProperties(). Add
implementation of setTextColor().
swf9/LzTextSprite - swf/LzTextSprite - Set text color in
__initTextProperties(). Rename setColor() -> setTextColor().
swf9/LzSprite - Remove setColor(), getColor().
LzText - Prevent extra sprite updates for font,fontsize,fontstyle and
fgcolor setters. Hide private methods from docs. fgcolor setter calls
sprite.setTextColor().
LaszloView - Remove hasfgcolor property. Default fgcolor to null to
enable cascading. Remove calls to sprite.setColor() in fgcolor setter.
Deprecate getColor(), return local property for now.
LaszloCanvas - Remove hasfgcolor property, correct comment about
canvas not changing size.
Tests: See LPP-8422 across runtimes. All other apps, e.g. calendar run
as before.
Files:
M WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100331-maxcarlson-8.tar
