approved On Mon, Apr 19, 2010 at 6:38 PM, P T Withington <[email protected]> wrote: > Approved! > > I think that new warning is useful. > > I wonder if rather than every subclass having to check for deleted in > construct, we should have a try/catch that is internal to LzNode -- it puts a > try block around the call to construct and in the default constructor, where > it would return because of early deletion, it should throw (not an error, but > a private instance that it catches) to abort any sub-constructors too? > > On 2010-04-16, at 20:35, Max Carlson wrote: > >> Change 20100416-maxcarlson-R by [email protected] on 2010-04-16 16:34:20 >> PDT >> in /Users/maxcarlson/openlaszlo/trunk-clean >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Eliminate warnings in the component sampler >> >> Bugs Fixed: LPP-8920 - Ensure all LFC calls to sendEvent() check the ready >> flag first >> >> Technical Reviewer: ptw >> QA Reviewer: hminsky >> >> Details: Ensure all LFC calls to sendEvent() check the ready flag >> first. >> >> LaszloView, LzText, LzInputText - Return early from constructors when the >> node has been deleted, which can happen due to replication or placement. >> >> Tests: examples/components/component_sampler.lzx?debug=true no longer warns >> about invalid delegates. >> >> Files: >> M WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as >> M WEB-INF/lps/lfc/services/LzGlobalMouse.lzs >> M WEB-INF/lps/lfc/services/LzFocus.lzs >> M WEB-INF/lps/lfc/views/LzInputText.lzs >> M WEB-INF/lps/lfc/views/LzText.lzs >> M WEB-INF/lps/lfc/views/LaszloView.lzs >> M WEB-INF/lps/lfc/views/LaszloCanvas.lzs >> M WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs >> M WEB-INF/lps/lfc/data/LzDatapath.lzs >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20100416-maxcarlson-R.tar >> > >
-- Henry Minsky Software Architect [email protected]
