Not approved:
1) wrong path for excanvas include
<script type="text/javascript" src="/trunk-clean/lps/includes/excanvas.js">
2) splice(1) and splice(1,1) are different things
- splice(i) returns all elements starting at index i (inclusive)
- splice(i,n) returns n elements starting at index i (inclusive)
You actually want: 'seq.splice(1, seq.length - 1)'
3) validateReferenceDependencies() is only needed in contextmenu.js,
because it's compiled with the -g option. Is this necessary at all? It
seems to be more correct to remove the -g option when compiling
contextmenu.lzx
On 5/20/2010 12:16 AM, Max Carlson wrote:
Change 20100519-maxcarlson-F by maxcarl...@friendly on 2010-05-19 15:07:38 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix laszlo-explorer in IE 8 DHTML
Bugs Fixed: LPP-9003 - DHTML: right click throws exception (IE8)
Technical Reviewer: [email protected]
QA Reviewer: ptw
Details: LzRuntime - since WEB-INF/lps/lfc/contextmenu is essentially an LZO,
it includes code for verifying reference dependencies - which won't work when
included as part of the DHTML LFC. Add a stub version for non-debug mode.
explore-nav.lzx - Add explicit second argument to Array.splice() for
compatibility in IE DHTML.
index.html - Move LFC include to body, add conditional include for excanvas for
IE.
explore-nav* - Recompile explore-nav SOLO apps
Tests: explore-nav/index.html?lzr=dhtml now works properly in IE DHTML, other
browsers show the context menu when the explore app is right-clicked.
Files:
M WEB-INF/lps/lfc/compiler/LzRuntime.lzs
M laszlo-explorer/explore-nav.swf8.swf
M laszlo-explorer/explore-nav.js
M laszlo-explorer/explore-nav.swf10.swf
M laszlo-explorer/index.html
M laszlo-explorer/explore-nav.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100519-maxcarlson-F.tar
