Oh right, I forgot the LzSprite file. I tend to agree with you though, quirk not needed. I'm going to go with that approach.
On Wed, Jun 2, 2010 at 10:06 AM, P T Withington <[email protected]>wrote: > I think there must still be a file missing, because > > + if ($swf10) { > + cursor = MouseCursor.BUTTON; > + } else if (LzSprite.quirks.fixclickabletextcursor) { > + // This is a workaround for LPP_8710, to make a > button cursor in swf9 > + cursor = "__LFCSWF9handcursor"; > + } > > I assume fixclickabletextcursor is the new quirk max asked for, but I don't > see any change adding that quirk. > > I disagree that we need a quirk for this, but I would rewrite the if to be: > > if ($swf9) { > // This is a workaround for LPP_8710, to make a > button cursor in swf9 > cursor = "__LFCSWF9handcursor"; > } else { > cursor = MouseCursor.BUTTON; > } > > Then it is obvious that the work-around is only for swf9 and can go away > when swf9 does. > > On 2010-06-02, at 07:27, Henry Minsky wrote: > > > Change 20100601-hqm-6 by [email protected] on 2010-06-01 17:23:21 EDT > > in /Users/hqm/openlaszlo/trunk2 > > for http://svn.openlaszlo.org/openlaszlo/trunk > > > > Summary: fix for clickable text handcursor in swf9 > > > > New Features: > > > > Bugs Fixed: LPP-8710 > > > > Technical Reviewer: max > > QA Reviewer: ptw > > Doc Reviewer: (pending) > > > > Documentation: > > > > Release Notes: > > > > Overview: > > > > Add an explicit hand cursor resource for swf9, to allow cursor to be > changed > > to handcursor when mouse over clickable text > > > > Details: > > > > > > Tests: > > > > Test case below, run with lzr=swf9, mouse cursor should change to button > hand when mouseover > > text view. > > > > > > <canvas> > > <text onclick="Debug.warn('click')">Clickable text should show a hand > cursor</text> > > </canvas> > > > > > > Files: > > M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java > > M WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as > > M > WEB-INF/lps/server/src/org/openlaszlo/compiler/ResourceCompiler.java > > A lps/components/lz/resources/handcursor.png > > > > > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100601-hqm-6.tar > > -- Henry Minsky Software Architect [email protected]
