I'm still having problems, even after following your instructions.

Issues:

1) We don't document implicit events, events associated with attributes, 
because they just clutter the documentation.  So you should make onclickmask 
private.

2) What about onclickregion?

3) Is there no way to unify these interfaces?  I can't really see what the 
difference is.  Don't they both take resources that describe the hotspot?

4) Your change is stale, needs to be updated to ToT.

5) Mask does not work in swf8.  The whole rectangle is always clickable.

6) DHTML gives "lpp-9089.lzx:2:46: file not found: mask.swf"

Not approved.

On 2010-06-16, at 20:16, Max Carlson wrote:

> Hmm, I just tried and it works for me - as long as I download the full test 
> attached to http://jira.openlaszlo.org/jira/browse/LPP-9089, do a full 
> recompile to add 'clickmask' to the schema, and run as 
> my-apps/lpp-9089/lpp-9089.lzx?lzr=swf10/swf8.  Doing this, I don't see any 
> compiler warnings or errors, and the testcase works flawlessly...
> 
> Regards,
> Max Carlson
> OpenLaszlo.org
> 
> On 6/14/10 2:40 PM, P T Withington wrote:
>> Not approved:
>> 
>> Errors:
>> 
>> swf8:
>> 
>> lpp-9089.lzx:4:298: found an unknown attribute named "clickmask" on element 
>> view, however there is an attribute named "mask" on class attribute", did 
>> you mean to use that?
>> 
>> swf10:
>> 
>> Compilation Errors
>> 
>> org.openlaszlo.sc.CompilerError: lpp-9089.lzx: 4: Error: Access of undefined 
>> property clipper, in line: canvas.LzInstantiateView({attrs: {$delegates: 
>> ["onclick", "$m611", null, "ondblclick", "$m612", null], bgcolor: 
>> LzColorUtils.convertColor("0xff0000"), clickable: true, clickmask: clipper, 
>> height: 40, resource: "clipper", stretches: "both", width: 40, x: 100, y: 
>> 100}, "class": $lzc$class_m613}, 1);lz["debug"] = 
>> $lzc$class_debug;lz["basefocusview"] = 
>> $lzc$class_basefocusview;lz["focusoverlay"] = 
>> $lzc$class_focusoverlay;lz["_componentmanager"] = 
>> $lzc$class__componentmanager;lz["style"] = $lzc$class_style;lz["statictext"] 
>> = $lzc$class_statictext;lz["basecomponent"] = 
>> $lzc$class_basecomponent;lz["basebutton"] = 
>> $lzc$class_basebutton;lz["simplelayout"] = 
>> $lzc$class_simplelayout;lz["simpleboundslayout"] = 
>> $lzc$class_simpleboundslayout;lz["resizelayout"] = 
>> $lzc$class_resizelayout;lz["stableborderlayout"] = 
>> $lzc$class_stableborderlayout;lz["constantlayout"] = $lzc$class_constant!
 la
> yout;lz["constantboundslayout"] = 
> $lzc$class_constantboundslayout;lz["wrappinglayout"] = 
> $lzc$class_wrappinglayout;lz["reverselayout"] = 
> $lzc$class_reverselayout;lz["resizestate"] = 
> $lzc$class_resizestate;lz["dragstate"] = 
> $lzc$class_dragstate;lz["_dbg_lzhdrag"] = 
> $lzc$class__dbg_lzhdrag;lz["_dbg_horiz_scrollbar"] = 
> $lzc$class__dbg_horiz_scrollbar;lz["_dbg_lzvdrag"] = 
> $lzc$class__dbg_lzvdrag;lz["_dbg_lztextscroller"] = 
> $lzc$class__dbg_lztextscroller;lz["tooltip"] = 
> $lzc$class_tooltip;lz["basevaluecomponent"] = 
> $lzc$class_basevaluecomponent;lz["baseformitem"] = 
> $lzc$class_baseformitem;lz["multistatebutton"] = 
> $lzc$class_multistatebutton;lz["checkbox"] = 
> $lzc$class_checkbox;lz["swatchview"] = $lzc$class_swatchview;lz["button"] = 
> $lzc$class_button;lz["resizestatemin"] = 
> $lzc$class_resizestatemin;lz["basewindow"] = 
> $lzc$class_basewindow;lz["resizeview_x"] = 
> $lzc$class_resizeview_x;lz["resizeview_y"] = 
> $lzc$class_resizeview_y;lz["windowpanel"] = $lzc$class_windowpanel;lz["modal!
 dia
> log"] = $lzc$class_modaldialog;lz["alert"] = $lzc$class_alert;lz["window"] = 
> $lzc$class_window;lz["baseslider"] = 
> $lzc$class_baseslider;lz["baseslidertrack"] = 
> $lzc$class_baseslidertrack;lz["basesliderthumb"] = 
> $lzc$class_basesliderthumb;lz["sliderthumb"] = 
> $lzc$class_sliderthumb;lz["slidertrack"] = 
> $lzc$class_slidertrack;lz["slider"] = 
> $lzc$class_slider;lz["debugger_shadow_bottom"] = 
> $lzc$class_debugger_shadow_bottom;lz["debugger_shadow_right"] = 
> $lzc$class_debugger_shadow_right;lz["LzDebugWindow"] = 
> $lzc$class_LzDebugWindow;Debug.makeDebugWindow();addChild(canvas.sprite);canvas.initDone();}lpp-9089.lzx:4:298:
>  found an unknown attribute named "clickmask" on element view, however there 
> is an attribute named "mask" on class attribute", did you mean to use that?
>> Compilation Warnings
>> 
>> lpp-9089.lzx:4:298: found an unknown attribute named "clickmask" on element 
>> view, however there is an attribute named "mask" on class attribute", did 
>> you mean to use that?
>> 
>> DHTML:
>> 
>> 
>> Compilation Errors
>> 
>> lpp-9089.lzx:2:46: file not found: mask.swf
>> 
>> On 2010-06-05, at 02:27, Max Carlson wrote:
>> 
>>> Change 20100604-maxcarlson-Q by maxcarl...@friendly on 2010-06-04 23:25:17 
>>> PDT
>>>    in /Users/maxcarlson/openlaszlo/trunk-clean
>>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>> 
>>> Summary: Add view.clickmask attribute to set the click mask to a resource
>>> 
>>> New Features: view.clickmask allows the view's click region to be set.
>>> 
>>> Bugs Fixed: LPP-9089 - Add ability to use resource as a click mask
>>> 
>>> Technical Reviewer: hminsky
>>> QA Reviewer: ptw
>>> 
>>> Release Notes: view.clickmask allows the view's click region to be set.
>>> 
>>> Details: LzSprite.as - Set clickmask capability to true, add setClickMask() 
>>> implementation.
>>> 
>>> LaszloView - if clickmask capability is true, call sprite.setClickMask() 
>>> with the appropriate resource ID.
>>> 
>>> Tests: See LPP-9089
>>> 
>>> Files:
>>> M       WEB-INF/lps/lfc/kernel/swf/LzSprite.as
>>> M       WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
>>> M       WEB-INF/lps/lfc/views/LaszloView.lzs
>>> 
>>> Changeset: 
>>> http://svn.openlaszlo.org/openlaszlo/patches/20100604-maxcarlson-Q.tar
>> 


Reply via email to