Comments: 1) makeLZOClassname already does the canonical/relative path bit, so there is no need to before calling it.
2) maybe you should rename `makeLZOClassname` to something like `fileToSymbol`? Otherwise, approved. On 2010-06-22, at 13:43, Henry Minsky wrote: > > > > Change 20100622-hqm-V by [email protected] on 2010-06-22 13:32:12 EDT > in /Users/hqm/openlaszlo/trunk3 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: fix for lzo pathname bug on windows > > New Features: > > Bugs Fixed: LPP-9141 cannot compile a .lzo for swf10 on Windows which > depends on external include > > Technical Reviewer: ptw > QA Reviewer: (pending) > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > > Details: > > SWF9Writer.java: > > When building an application, if the compiler encounters any swf10 > .swc files in any lzo's it is using, it copies the .swc files out to > the temp build directory so that the flex compiler can see them. In > this case, it was constructing a poorly formed pathname, which caused > an IO error. > > This fix uses the "safe name" code from the LibraryWriter, to > construct the tmp pathname to place the .swc, so that is has no > special filesystem chars in it. > > Tests: > > In Windows XP, compile these lzo library files. The compile of lib2.lzx is > where the error would > happen, because it references an external lzo library which needs to be > unpacked by the compiler > and copied to the build directory. > > cd test\testlzo > > set LPS_HOME=Z:\openlaszlo\trunk3 > > set JAVA_HOME=C:\Program Files\Java\jdk1.6.0_17 > > call %LPS_HOME%\WEB-INF\lps\server\bin\lzc.bat "-DJAVA_HOME=%JAVA_HOME%" > "-DLPS_HOME=%LPS_HOME%" "-Dnodeploy" "-Dlzproxied=false" "--runtime=swf10" -c > --runtime=swf10 extclass.lzx > > call %LPS_HOME%\WEB-INF\lps\server\bin\lzc.bat "-DJAVA_HOME=%JAVA_HOME%" > "-DLPS_HOME=%LPS_HOME%" "-Dnodeploy" "-Dlzproxied=false" "--runtime=swf10" -c > --runtime=swf10 libdir/lib2.lzx > > ^^^^^^ This is the place an error would occur > > > > call %LPS_HOME%\WEB-INF\lps\server\bin\lzc.bat "-DJAVA_HOME=%JAVA_HOME%" > "-DLPS_HOME=%LPS_HOME%" "-Dnodeploy" "-Dlzproxied=false" "--runtime=swf10" > --runtime=swf10 main.lzx > > > Files: > M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100622-hqm-V.tar
