Comment: 1) What is the purpose of `if (radii.length > 0)` in the DHTML sprite? It seems you have changed the kernel API to always require an array as the radius spec.
2) Are you going to regret not permitting separate horizontal and vertical radii? Maybe if you are going this far, you should add that too? Issue: 1) The change in order of parameters to drawview/rect is a public API change so should be proposed on Laszlo-user first, no? 2) Suggest the parameters be documented in the same order Otherwise, approved. On 2010-07-03, at 12:22, Max Carlson wrote: > Change 20100703-maxcarlson-1 by maxcarl...@friendly on 2010-07-03 09:15:55 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Add support for setting discreet corners' CSS3 border radius > > Bugs Fixed: LPP-8745 - Add support for border-radius to view > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: */LzSprite - Update setCornerRadius() to expect an array of four > radii instead of just one. > > drawview, LzKernelUtils - Update rect() to take corner radii in clockwise > order, a la the w3c standard. > > LaszloView - shadowblurradius and shadowdistance bot convert really small > numbers to 0. cornerradius defaults to a string value now. > set_cornerradius() handles giving each corner a default radius per the w3c > standard. > > > > > Tests: > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as > M WEB-INF/lps/lfc/kernel/LzKernelUtils.lzs > M WEB-INF/lps/lfc/views/LaszloView.lzs > M lps/components/extensions/drawview.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100703-maxcarlson-1.tar
