Approved, but you need one change.
In html.lzx change:
Debug.warn('init', i);
//if (i) this.setiframeid(i);
to:
//Debug.warn('init', i);
if (i) this.setiframeid(i);
The rte example now works completely!
On Wed, Jul 28, 2010 at 7:38 PM, Max Carlson wrote:
Change 20100728-maxcarlson-c by maxcarl...@friendly on 2010-07-28
14:47:19 PDT
in /Users/maxcarlson/openlaszlo/trunk2
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Break iframemanager.js out into a separate include
Bugs Fixed: LPP-9245 - Break up embedding JS includes (partial)
Technical Reviewer: promanik
QA Reviewer: hminsky
Details: DeploySOLO*, solo-* - Add iframemanager.js
html.lzx - Add swf proxy method for __createcallback(), called when
iframemanager is loaded and has an id. Store a reference to the owner
in create().
rte.lzx - Fix a couple of bad callJavascript() calls
embednew - Shorten lookups. Move __dhtmlLoadLibrary() to public API
loadJSLib(), improve to avoid loading the same URL more than once.
Add jsloaded hashtable that can be used to tell the status of a .js
loaded with loadJSLib(). getServerRoot() caches lookup value.
embed-library - Replace iframemanager with iframemanagerstub.
iframemanagerstub - Add stub create() method that captures all
arguments, loads iframemanager.js, then creates the iframes and calls
back into the LZX to let the <html/> continue initializing.
iframemanager - Update __gotload() to provide inital load notification
so setHTML() can be called. Clean up __destroy() so it won't fail for
DHTML-specific calls.
build.xml - Add separate build target for iframemanager.js.
Tests: examples/extensions/html.lzx and examples/extensions/rte.lzx
run as before.
Files:
M WEB-INF/lps/server/src/org/openlaszlo/utils/DeploySOLOSWF.java
M
WEB-INF/lps/server/src/org/openlaszlo/utils/DeploySOLODHTML.java
M lps/components/extensions/html.lzx
M lps/components/extensions/rte.lzx
M lps/includes/source/embednew.js
M lps/includes/source/embed-library.lzs
A lps/includes/source/iframemanagerstub.js
M lps/includes/source/iframemanager.js
M lps/includes/source/build.xml
M lps/admin/solo-deploy.jsp
M lps/admin/solo-dhtml-deploy.jsp
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100728-maxcarlson-c.tar
