Approved, though there are some visual artifacts in SWF - the dojo iframe appears to overlap the bottom of the window. In DHTML its clipped to the height of the window.

Also, the 'All Bold' button is missing its resources. See the attached image.


On 7/28/10 1:38 PM, [email protected] wrote:
Change 20100728-philip-DPT by phi...@philip-i7 on 2010-07-28 16:33:52 EDT
in /cygdrive/c/clients/laszlo/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: RTE: Fix component to run in swf

New Features:

Bugs Fixed: LPP-9244

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Overview:


Details:
Fix RTE component so it works in all platforms.

lps/components/extensions/rte.lzx
- use lz.embed.getServerRoot to find the location of rtewrapper.html
- Set the dojo theme and root after the page is loaded.

lps/includes/rtewrapper.html
- Fixed the style and added an id so the div can be styled in code.

lps/includes/source/rtemanager.js
- Only set debugAtAllCosts if you are loading dojo locally.
- Listen to editor onChange event to respond to changes when focus is lost.
- Added methods to set the dojo path and theme.

examples/extensions/rte.lzx
- Fixed dragging behavior.

Tests:
/examples/extensions/rte.lzx works the same in swf/swf10 as dhtml.

Files:
M lps/components/extensions/rte.lzx
M lps/includes/rtewrapper.html
M lps/includes/source/rtemanager.js
M examples/extensions/rte.lzx
A examples/extensions/logo_small.png

Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100728-philip-DPT.tar


--
Regards,
Max Carlson
OpenLaszlo.org

<<attachment: Screen shot 2010-07-28 at 2.42.30 PM.png>>

Reply via email to