I think you want to put this comment back in LzCSSStyle:

   // Debug.info('found rules %w for %w, binders %w', rules, node, deps);

Otherwise, approved!

Regards,
Max Carlson
OpenLaszlo.org

On 8/20/10 2:07 PM, P T Withington wrote:
Change 20100820-ptw-w by [email protected] on 2010-08-20 17:00:34 EDT
     in /Users/ptw/OpenLaszlo/trunk-3
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Make CSS * rules work

Bugs Fixed:  LPP-9313 CSS `*` rules do not work

Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)

Details:
     LzCSSStyle: Use `in` to determine if an attribute rule could apply
     to a node.  Remove error from _rules 'catch all', since that is
     where '*' rules land.

     LzDebug, LzFormatter: (Noted in passing, inspecting LzCSSStyle
     object) Be more careful about testing debug descriptor strings,
     which may be null for some objects.

     StyleSheetCompiler: A null local name in an element selector is a
     `*` rule.  Export it as such, so the runtime parser detects it
     correctly.

Tests:
     Test case from bug.

Files:
M       WEB-INF/lps/lfc/services/LzCSSStyle.lzs
M       WEB-INF/lps/lfc/debugger/LzDebug.lzs
M       WEB-INF/lps/lfc/compiler/LzFormatter.lzs
M       WEB-INF/lps/server/src/org/openlaszlo/compiler/StyleSheetCompiler.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100820-ptw-w.tar

Reply via email to