approved On Fri, Aug 27, 2010 at 10:07 AM, P T Withington <[email protected]> wrote:
> Change ptw-20100827-jaO by [email protected] on 2010-08-27 09:51:47 EDT > in /Users/ptw/OpenLaszlo/trunk-2/test > for http://svn.openlaszlo.org/openlaszlo/trunk/test > > Summary: Don't rewrite identifier in super call > > Bugs Fixed: LPP-9310 bad as3 code if methodname and arg name are the same > when a super call is made > > Technical Reviewer: [email protected] (pending) > QA Reviewer: [email protected] (pending) > > Details: > > SWF9Generator: Need to intercept visitSuperCallExpression, not > just translateSuperCallExpression, because the latter expects a > re-written expression that needs variable substitution. For swf9, > we don't want that, since most super calls are not rewritten (only > super.setAttribute). > > GenericVisitor: Fix similar brain-oh here. The ID in a super > call is not a variable, it is a literal. > > Tests: > > Compiled test case from bug and inspected .as3 output to verify > the super expression has not been mis-translated. > > smokecheck > > Files: > M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java > M WEB-INF/lps/server/src/org/openlaszlo/sc/GenericVisitor.java > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/ptw-20100827-jaO.tar > -- Henry Minsky Software Architect [email protected]
