Sorry about the debug noise.

One question on `% 360`, is there a concern about negative rotations?  To my 
mind, a rotation of -450 ought to be normalized to +270, but the JS % operator 
is not defined to do that.  (The JS % operator, although everyone calls it mod, 
is really a rem operator, at least in Lispy terms.)

Otherwise approved.

On 2010-09-09, at 14:25, Max Carlson wrote:

> Change maxcarlson-20100908-jKh by maxcarl...@friendly on 2010-09-08 19:58:46 
> PDT
>   in /Users/maxcarlson/openlaszlo/trunk-clean
>   for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: More tuning, speedups
> 
> Bugs Fixed: LPP-9333  - lz.view getAttributeRelative() doesn't work with 
> nested views inside a view that has xscale/yscale, LPP-6892 -  Generated File 
> Sizes baseline complete; Performance Tuning ongoing
> 
> Technical Reviewer: ptw
> QA Reviewer: hminsky
> 
> Details: LzUtils - Math.floor() -> | 0. 
> 
> LzViewLinkage - Clean up stray debug statement
> 
> LaszloView - Math.floor() -> | 0, add % 360 for rotation setter.
> 
> Tests: All apps run as before, but with fewer Debug messages
> 
> Files:
> M       WEB-INF/lps/lfc/services/LzUtils.lzs
> M       WEB-INF/lps/lfc/views/LzViewLinkage.lzs
> M       WEB-INF/lps/lfc/views/LaszloView.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20100908-jKh.tar


Reply via email to