Yeah, it does as far as the computation is concerned. I just couldn't get single line to look right with more padding in Safari.

On 9/15/10 6:42 AM, P T Withington wrote:
Just one question:  doesn't the padding around input text need to always add up 
to 4 for swf compatibility?

On 2010-09-14, at 15:42, Max Carlson wrote:

Change 20100914-maxcarlson-D by maxcarl...@friendly on 2010-09-14 11:12:00 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: DHTML: fix inputtext clickability

Bugs Fixed: LPP-9268 - DHTML: padding is not subtracted from width/height for 
texts

Technical Reviewer: [email protected]
Technical Reviewer: ptw
QA Reviewer: hminsky

Details: LzSprite - Tweak padding for inputtexts to match flash, using 
examples/components/edittext_example.lzx as a baseline.  Add 
prevent_selection_with_onselectstart quir, set to true in IE.  Tweak letter 
spacing to match Flash.

LzTextSprite - Set default of selectable flag to match LzText.  Add property 
for multiline, default to false.  Move boolean coercing to LzText.  Simplify 
setSelectable().  Add more caching to setWidth/Height, ensure we return the 
correct width/height for LzInputTextSprite.setWidth/Height.

LzInputTextSprite - Clean out cruft. For setWidth/Height, add more caching, 
ignore null values and use this.CSSDimension() to get a CSS value before 
applying it.

LzText - Add typing, boolean coercing for argument values.

Tests: examples/components/edittext_example.lzx looks almost identical across 
runtimes/browsers.  I can click the amazon edit text again in DHTML.

Files:
M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M       WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M       WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M       WEB-INF/lps/lfc/views/LzText.lzs

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20100914-maxcarlson-D.tar

Reply via email to