Change hqm-20100917-shr by [email protected] on 2010-09-17 12:15:33 EDT
in /Users/hqm/openlaszlo/trunk3
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: remove compile-time text metrics measurement
New Features:
Bugs Fixed:
Technical Reviewer: ptw
QA Reviewer: max
Doc Reviewer: (pending)
Documentation:
Release Notes:
Overview:
+ remove code from ViewCompiler which calculates text width and font style
inheritance at compile-time. It doesn't
work anymore, and the runtime does it properly now.
Note: This change just removes the text metrics and font inheritance
stuff, and does not address the new proposal regarding an 'html'
attribute and using CDATA to specify verbatim text.
Details:
NodeModel:
Modified addText() so it only adds text content if the tag is known to have a
text attribute (previously, it was adding
text by default to any element which had text content)
Add warning if an element has both a text attribute and any non-whitespace
literal text in it's content.
ViewCompiler:
compile(): remove call to mapTextMetricsCompilation
remove mergeClassFontInfo() method, no longer needed
TextCompiler:
remove computeTextWidth() method
getElementWidth renamed to getHTMLContent, as it is now only used to collect
the HTML text from the node's Content.
I'm passing CompilationEnvironment down to it, in case we need this code to
emit any compilation warnings at some point,
but it's not used right now.
LineMetrics:
Remove code that tries to calculate char width from font metrics. This code
now just is used by TextCompiler to
accumulate HTML content while normalizing out whitespace.
Tests:
ant lztest
compile demos without compilation errors or warnings:
calendar,amazon,weather,youtube,lzproject,
examples/components/component_sampler
examples/components/form_example
examples/components/grid_example
examples/components/tree_example
examples/components/tabs_example.lzx
Files:
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/LineMetrics.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/TextCompiler_Test.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/TextCompiler.java
M demos/calendar/event.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/hqm-20100917-shr.tar
