Not approved. This is just asking for trouble, to have setX, _setX, and __setX. How is anyone supposed to understand this code?
If you feel you must do this, could we at least use some more mnemonic names so there is 1/2 a chance of understanding what is going on? Like maybe: foo.prototype.$foo$bar = foo.prototype.bar etc? It's just too easy to make a 1-character type-oh with the change as proposed. [Jesus, I wish we had not decided that we can't use lzs for our kernels.] On 2010-09-22, at 16:55, Max Carlson wrote: > Change maxcarlson-20100922-f7o by maxcarl...@friendly on 2010-09-22 13:53:06 > PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Reduce use of function.call() > > Bugs Fixed: LPP-6892 - Generated File Sizes baseline complete; Performance > Tuning ongoing > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: LzTextSprite, LzInputTextSprite - Cache 'super' values and use an > explicit call, instead of using call() which is slow. See > http://jsperf.com/call-vs-apply/3 for a test. > > Tests: All dhtml apps run as before > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js > M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20100922-f7o.tar
