On Wed, Sep 22, 2010 at 11:53 PM, Max Carlson <[email protected]> wrote:
> You have a typo here:
>
> - if (quirks.fix_clickable && quirks.dont_clip_clickdivs != true) {
> + if (quirks.fix_clickable && quirks.dont_clip_clickdivsa != true) {
>
> Also, shouldn't the test to avoid copying clip be in __copystyles() instead
> of clearing the style after the fact?
>
> I see you've commented out the bit that copies the clip style altogether:
> - to.style.clip = sprite._clip;
> + //to.style.clip = sprite._clip;
> }
>
Maybe that part should be conditionalized based on the quirk...
>
>
oops sorry I sent the wrong version of my patch. Yes, I meant to
conditionalize on
both the type being 'click' and on the quirk, and was going to pass a flag
down to copystyles. I'll send the update in a sec.
> On 9/22/10 8:22 PM, Henry Minsky wrote:
>
>> Change hqm-20100922-M2l by [email protected] on 2010-09-22 23:20:39 EDT
>> in /Users/hqm/openlaszlo/trunk-clean
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: fix for DHTML clickdivs in Opera
>>
>> New Features:
>>
>> Bugs Fixed: LPP-9380, LPP-9382
>>
>> Technical Reviewer: max
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Overview:
>>
>>
>> Details:
>>
>> always remove clipping from clickdivs in Opera
>>
>>
>> Tests:
>>
>>
>> tabsliders and menus work in:
>> examples/components/component_sampler.lzx?lzr=dhtml
>>
>>
>> Files:
>> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>>
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/hqm-20100922-M2l.tar
>>
>
--
Henry Minsky
Software Architect
[email protected]
