Comment: 1) Why not wrap `if (LzKeyboardKernel.__cancelKeys)` around the whole computation? No point in calculating `ignore` if you are not doing any cancelling.
But, not approved: 1) If I tab to the 'caviar' menu and try to arrow up/down to select another choice, it causes the window to scroll instead of moving the selection. That's a regression. On 2010-09-24, at 16:30, Henry Minsky wrote: > Change hqm-20100923-d2m by [email protected] on 2010-09-23 13:15:23 EDT > in /Users/hqm/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: ensure spacebar key does not cause browser scrolling in > DHTML/Opera/Safari > > New Features: > > Bugs Fixed: LPP-9381 > > Technical Reviewer: max > QA Reviewer: ptw > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > > Details: > > Check to see if event.which is supported by browser key event > > > Tests: > > + Run examples/components/component_sampler.lzx?lzr=dhtml, > and size browser height short enough so there is a vertical scrollbar. > Click on a checkbox and press spacebar to toggle it's value. The browser > window should not scroll. > > Verify that tab key correctly moves focus bars, and does not focus on > the debugger input field > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js > > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/hqm-20100923-d2m.tar
