Approved for QA! On 10/2/10 8:53 AM, Henry Minsky wrote:
Change hqm-20101002-pKd by [email protected] on 2010-10-02 09:31:54 EDT in /Users/hqm/openlaszlo/trunk-clean for http://svn.openlaszlo.org/openlaszlo/trunkSummary: fix for swf8 lzo compilation New Features: Bugs Fixed: (LPP-9422) lzo mixin test fails in swf8 Technical Reviewer: ptw QA Reviewer: max Doc Reviewer: (pending) Documentation: Release Notes: Overview: The way that LZO files are compiled, the platform-independent lzo file in LZO files gets run through the LZX compiler, to get the<interface> schema info. There is also a<script> block in there that contains the platform-independent intermediate javascript code for the library. The ScriptElementCompiler gets to decide whether to use that platform-independent code, or to ignore it with the knowledge that there is a linkable platform-specific library object file in the LZO which contains the precompiled code, which will get linked in, bypassing the script compiler. This all works nicely for SWF10 and DHTML, but for swf8, there is no linkable platform-specific object file, and yet the conditions that ScriptElementCompiler was looking for were satisfied, so the script element was just being silently ignored. I added a table to Compiler public static List BINARY_LINKABLE_RUNTIMES = Arrays.asList(new String[] {"swf10", "swf9", "dhtml"}); which lists the runtimes where we actually expect to find a platform-specific binary library in the lzo Details: DHTMLWriter: fix out of date comment runlzunit.sh: try to find any firefox profile to frob the 'allow windows to be closed' flag Tests: "ant runbrowserlztest-swf8 " succeeds "ant runlzunit" succeeds Files: M WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java M WEB-INF/lps/server/src/org/openlaszlo/compiler/ScriptElementCompiler.java M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java M build-tools/runlzunit.sh Changeset: http://svn.openlaszlo.org/openlaszlo/patches/hqm-20101002-pKd.tar
